Release Candidate v0.0.5 #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BUG/TST: update test behavior in the absence/presence of pysatCDF
DOC: ICON constellation info
ENH: Add DE2 instruments
BUG: data uniqueness for GOLD
Co-authored-by: Jeff Klenzing <[email protected]>
|
Downstream package error documented at pysat/pysatModels#128 |
jklenzing
requested review from
aburrell,
JonathonMSmith,
rstoneback and
t-esman
aburrell
reviewed
Jun 15, 2023
pysatNASA/tests/test_instruments.py
Outdated
Comment on lines
11
to
19
| import pysat | ||
| import pytest | ||
|
|
||
| # Make sure to import your instrument library here | ||
| import pysatNASA | ||
|
|
||
| # Import the test classes from pysat | ||
| from pysat.tests.classes import cls_instrument_library as clslib | ||
| from pysat.utils import testing |
There was a problem hiding this comment.
All the pysat imports should be grouped together. I recommend moving up pytest to the warnings block and moving all the pysat imports above the pysatNASA import.
Co-authored-by: Angeline Burrell <[email protected]>
Co-authored-by: Angeline Burrell <[email protected]>
aburrell
approved these changes
Jun 22, 2023
|
We need one more review. Pinging @JonathonMSmith and @rstoneback |
JonathonMSmith
approved these changes
Jun 27, 2023
jklenzing
commented
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Release Candidate for version 0.0.5.
The v0.0.5 release adds multiple new instruments, as well as improves support for xarray datasets. There are multiple updates for compatibility with the latest versions of
cdflib,xarray, andpysat.Type of change
How Has This Been Tested?
via pytest at github actions
Checklist:
CHANGELOG.md, summarizing the changes